Skip to content

Create phasor dynamics model data structures #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 5 commits into from
Closed

Create phasor dynamics model data structures #115

wants to merge 5 commits into from

Conversation

pelesh
Copy link
Collaborator

@pelesh pelesh commented May 27, 2025 •
edited
Loading

Description

@abirchfield @lukelowry @alexander-novo @reid-g @abdourahmanbarry

Proposed changes

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • The new code follows GridKit™ style guidelines.
  • There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.

Further comments

@pelesh pelesh self-assigned this May 27, 2025
@pelesh pelesh added the enhancement New feature or request label May 27, 2025
pelesh and others added 5 commits May 27, 2025 12:58
@pelesh
Move PowerSystemsData.hpp and CircuitGraph.hpp to correct subdire…
15602b7 
…ctories (#114)

* Mowe PowerSystemsData.hpp to src/Models/PowerFlow.

* Move CircuitGraph.hpp to Model/PowerElectronics

* Move Matpower parser to src/Model/PowerFlow

---------

Co-authored-by: pelesh <pelesh@users.noreply.github.com>
@pelesh
Create phasor dynamics bus and branch data structures.
1a92315
@pelesh
Add load data structure.
109b8c5
@pelesh
Apply pre-commmit fixes
205f729
@pelesh
Use BusData with BusInfinite.
8a10d71
@pelesh pelesh force-pushed the slaven/phasor_dynamics_data_dev branch from 606efaa to 8a10d71 Compare May 27, 2025 17:16
@superwhiskers
Copy link
Collaborator

i don't think this is related to any change made in this pull request, but there's a segfault in the example AdjointSens in the destructor AnalysisManager::Sundials::Ida::~Ida caused by Ida::deleteAdjoint() calling IDAAdjFree(solver_) and then Ida::deleteSimulation() calling IDAFree(&solver_) which calls IDAAdjFree(...) as well. from what i can tell, the best way to solve this would be to remove the call to Ida::deleteAdjoint() in the destructor, but i could be wrong about this.

@pelesh
Copy link
Collaborator Author

pelesh commented May 27, 2025

i don't think this is related to any change made in this pull request, but there's a segfault in the example AdjointSens in the destructor AnalysisManager::Sundials::Ida::~Ida caused by Ida::deleteAdjoint() calling IDAAdjFree(solver_) and then Ida::deleteSimulation() calling IDAFree(&solver_) which calls IDAAdjFree(...) as well. from what i can tell, the best way to solve this would be to remove the call to Ida::deleteAdjoint() in the destructor, but i could be wrong about this.

This issue was supposed to be fixed in SUNDIAL PR 704. For now, we need to use SUNDIALS from develop branch.

@pelesh
Copy link
Collaborator Author

pelesh commented May 27, 2025

Closing this in favor of #116.

@pelesh pelesh closed this May 27, 2025
@superwhiskers superwhiskers mentioned this pull request May 28, 2025
Merged
@superwhiskers superwhiskers mentioned this pull request Jun 9, 2025
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@superwhiskers superwhiskers Awaiting requested review from superwhiskers

@nkoukpaizan nkoukpaizan Awaiting requested review from nkoukpaizan

Assignees

@pelesh pelesh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pelesh @superwhiskers